ferruzzi commented on PR #27823: URL: https://github.com/apache/airflow/pull/27823#issuecomment-1338280134
> Did you run all tessts from providers? breeze testing tests --test-type providers[amazon] Those should run full "amazon providers" suite in the same sequence they are run in CI - run them on main and see they don't fail. But they do, that's what I was saying. There are two tests in hooks/s3.py that fail when I run them locally even when I run them using breeze from main without my code. I can work on figuring out why and fixing them, but if they fail in breeze in main then I don't see how the code in this PR is the issue. That should be a separate PR to fix them. **FAILED tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3HookNoMock::test_check_for_bucket_raises_error_with_invalid_conn_id** (Note, this one is no longer failing in the CI and I have not caught up on my messages from yesterday or this morning, this may already be fixed) > /test_s3.py::TestAwsS3HookNoMock::test_check_for_bucket_raises_error_with_invalid_conn_id test fail locally because you have credentials in shared credentials file in default profile. Yup, that looks right. I propose that if that test expects to not find one, then it should mock the check to see if there is one and return false. Does that sound like the fight fix to that one to you two? If we like that solution I can make the fix but I think it belongs in a different PR. **FAILED tests/providers/amazon/aws/hooks/test_s3.py::TestAwsS3Hook::test_create_bucket_no_region_regional_endpoint** When run directly (not in breeze) locally it returns an exception that the bucvket already exists, when run in breeze it fails witht he message `botocore.exceptions.ClientError: An error occurred (InvalidAccessKeyId) when calling the CreateBucket operation: The AWS Access Key Id you provided does not exist in our records.` I want to say that sounds like it is not mocking the S3 connection and is actually hitting the live S3 API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
