ferruzzi commented on PR #27823: URL: https://github.com/apache/airflow/pull/27823#issuecomment-1342254484
Sorry for the holdup, this should pass now. All tests are passing on my side now in Breeze. Here's what I came up with: on [L414 here](https://github.com/apache/airflow/pull/27823/commits/47b69dfada6daa2440c498e38f54c6f8262b1542#diff-4e7fd0a0e31b60e534f7cab71ee4d3591c0758c1e76054f2403b6669546cb2d2L414) I was defaulting to an empty Config() thinking that would be 'falsy' [here](https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/utils/connection_wrapper.py#L231) in the Connection wrapper, but it doesn't so it overrides the user-provided values if the user creates a Connection. So I moved the default to the BaseAws [config property](https://github.com/apache/airflow/pull/27823/commits/47b69dfada6daa2440c498e38f54c6f8262b1542#diff-4e7fd0a0e31b60e534f7cab71ee4d3591c0758c1e76054f2403b6669546cb2d2R532) and removed the option for that to be None. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
