potiuk commented on code in PR #28172:
URL: https://github.com/apache/airflow/pull/28172#discussion_r1041553775
##########
airflow/models/taskinstance.py:
##########
@@ -1144,7 +1144,10 @@ def next_retry_datetime(self):
delay = timedelta(seconds=delay_backoff_in_seconds)
if self.task.max_retry_delay:
delay = min(self.task.max_retry_delay, delay)
- return self.end_date + delay
+ try:
+ return self.end_date + delay
+ except OverflowError:
+ return pendulum.DateTime.max
Review Comment:
What would be realistic? According to the exponential back-off in this case
it's already off-limits. setting max is actually **before** where the normal
calculation would lead it, (just limited so that things would not fail). Do you
think we have another "realistic" date :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
