potiuk commented on code in PR #28172:
URL: https://github.com/apache/airflow/pull/28172#discussion_r1043526058
##########
airflow/models/taskinstance.py:
##########
@@ -1140,7 +1140,11 @@ def next_retry_datetime(self):
# of tries (around 50 if the initial delay is 1s, even fewer if
# the delay is larger). Cap the value here before creating a
# timedelta object so the operation doesn't fail.
- delay_backoff_in_seconds = min(modded_hash,
timedelta.max.total_seconds() - 1)
+ # the timedelta is limited to core.max_retry_delay_in_seconds
config value
+ # or 24 Hrs if not specified
+ delay_backoff_in_seconds = min(
+ modded_hash, conf.getint("core", "default_max_retry_delay",
fallback=24 * 60 * 60) - 1
Review Comment:
Yeah. But I think it makes no sense to make it overrideable. That should be
a "global" parameter per whole Airflow instance and not overrideable at
DAG/TASK level.
So I updated it:
* changed the name to ``max_task_retry_delay``. This makes much more sense
to skip `default` (as it is not a default but only value) and add `task` for
consistency with `default_task_retry_delay` name.
* Added information that the value is not overrideable
* Added misc newsfragment to give a signal about it in release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
