ShelRoman commented on code in PR #28464:
URL: https://github.com/apache/airflow/pull/28464#discussion_r1052448782
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -126,14 +126,21 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
return response
def add_job_flow_steps(
- self, job_flow_id: str, steps: list[dict] | str | None = None,
wait_for_completion: bool = False
+ self,
+ job_flow_id: str,
+ steps: list[dict] | str | None = None,
+ wait_for_completion: bool = False,
+ waiter_delay: int = 5,
+ waiter_max_attempts: int = 100,
Review Comment:
yes, I considered options, but chose to keep it as closer to author's
decision.
Maybe even better option is to pass config as a parameter
```
def add_job_flow_steps(
self, job_flow_id: str, steps: list[dict] | str | None = None,
wait_for_completion: bool = False
self,
job_flow_id: str,
steps: list[dict] | str | None = None,
wait_for_completion: bool = False,
waiter_config: dict | None = None,
```
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -126,14 +126,21 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
return response
def add_job_flow_steps(
- self, job_flow_id: str, steps: list[dict] | str | None = None,
wait_for_completion: bool = False
+ self,
+ job_flow_id: str,
+ steps: list[dict] | str | None = None,
+ wait_for_completion: bool = False,
+ waiter_delay: int = 5,
+ waiter_max_attempts: int = 100,
Review Comment:
yes, I considered options, but chose to keep it as closer to author's
decision.
Maybe even better option is to pass config as a parameter
```
def add_job_flow_steps(
self, job_flow_id: str, steps: list[dict] | str | None = None,
wait_for_completion: bool = False
self,
job_flow_id: str,
steps: list[dict] | str | None = None,
wait_for_completion: bool = False,
waiter_config: dict | None = None,
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
