Taragolis commented on code in PR #28464:
URL: https://github.com/apache/airflow/pull/28464#discussion_r1052506327
##########
airflow/providers/amazon/aws/hooks/emr.py:
##########
@@ -126,14 +126,21 @@ def create_job_flow(self, job_flow_overrides: dict[str,
Any]) -> dict[str, Any]:
return response
def add_job_flow_steps(
- self, job_flow_id: str, steps: list[dict] | str | None = None,
wait_for_completion: bool = False
+ self,
+ job_flow_id: str,
+ steps: list[dict] | str | None = None,
+ wait_for_completion: bool = False,
+ waiter_delay: int = 5,
+ waiter_max_attempts: int = 100,
Review Comment:
Yep, in this case we reduce number of parameters.
But we need to be sure that we send as a dictionary (otherwise it raise an
error) and only `Delay` and `MaxAttempts` are acceptable parameters.
Unfortunetly waiters not well documented or better say `botocore` sources
are only the documentation of waiters internals:
https://github.com/boto/botocore/blob/6af5c29d9c71deb325eca99f24698303fc9e3dea/botocore/waiter.py#L336-L338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
