kfirgollan commented on PR #28520:
URL: https://github.com/apache/airflow/pull/28520#issuecomment-1361269015

   > I thought the same thing could be achieved by set appropriate PIP 
environment variables: 
https://pip.pypa.io/en/stable/topics/configuration/#environment-variables
   
   Well, that's true. But then again, its most likely the same case for the 
other installation flags used in the entrypoint for installations. Isn't it 
better to pick one approach and stick with it? IMHO if there is already an 
environment variable for installation options why not use it ? it merely feels 
like this environment variable was forgotten in this specific line.
   e.g why is it different from `ARG PIP_PROGRESS_BAR="on"`
   
https://github.dev/apache/airflow/blob/74e82af7eefe1d0d5aa6ea1637d096e4728dea1f/Dockerfile#L60
   @Taragolis 
   
   > I think the only REALLY good use of _PIP_ADDITIONAL_REQUIREMENTS is 
iteration during development and reinstalling/adding packages **while 
restarting your containers** in dev env. 
   
   I agree with this, in fact the main reason that I got to this point is that 
I am experimenting with 
[great_expectations](https://github.com/great-expectations/great_expectations) 
which takes a long time to install. So adding the cache to speed things up 
between container restarts is really significant.
   
   > However I would really appreciate if you could maybe instead @kfirgollan 
describe in our documentation an example workflow for development iteration 
instead - including the proxy and variabkle that need to be set instead.
   
   Sure thing, in place in particular in the docs directory that should be 
relevant for this?
   Also the question that arise is how to configure the cache - via a pip 
environment configuration? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to