uranusjr commented on code in PR #28520:
URL: https://github.com/apache/airflow/pull/28520#discussion_r1055117960
##########
Dockerfile:
##########
@@ -991,7 +991,9 @@ if [[ -n "${_PIP_ADDITIONAL_REQUIREMENTS=}" ]] ; then
>&2 echo " the container starts, so it is onlny useful for testing
and trying out"
>&2 echo " of adding dependencies."
>&2 echo
- pip install --root-user-action ignore --no-cache-dir
${_PIP_ADDITIONAL_REQUIREMENTS}
+ pip install --root-user-action ignore --no-cache-dir \
+ ${ADDITIONAL_PIP_INSTALL_FLAGS} \
+ ${_PIP_ADDITIONAL_REQUIREMENTS}
Review Comment:
If we’re separating the two I wonder if it’s a good idea to disallow options
in `_PIP_ADDITIONAL_REQUIREMENTS` by adding a `--` before it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
