dstandish commented on PR #28440: URL: https://github.com/apache/airflow/pull/28440#issuecomment-1362457897
one thing i should add too though is.... with this change, we might actually be able to remove the maintain propagate logic entirely. indeed we might be able to remove the recursive logger walking / propagate management in set_context as well. the reason is, since we move FTH to root (rather than copy) propagation doesn't matter, because there's nothing you can propagate to beyond root. it mattered when FTH was both at `airflow.task` and root because you could log twice. we wanted it at task because that's what `self.log` expected. and we wanted it at root so it could capture anything logged during task run (i.e. modules not children of airflow task). but because we had it in both places, we had to be careful about propagation. so this avoids that problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
