eladkal commented on code in PR #28538: URL: https://github.com/apache/airflow/pull/28538#discussion_r1056114079
########## airflow/providers/apache/hive/plugins/hive_plugin.py: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: You are refering to something else. The `provider_` was removed from everywhere. In peoviders with single service we do have tablue.py, hive.py but we dont have tableau_hooks.py So hive_plugins.py is not right. If you want hive.py i'm OK. The reason I suggested macros.py is beacuse plugins can be many things so telling that the file contains macros in the name is more self explained and will avoid adding there unrelated stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
