potiuk commented on code in PR #28538: URL: https://github.com/apache/airflow/pull/28538#discussion_r1056125327
########## airflow/providers/apache/hive/plugins/hive_plugin.py: ########## @@ -0,0 +1,42 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Yes I had for a while `hive_plugins.py` but it was gone already when you commented (pushed it a moment later). And we already have `hive.py` in `macros` package (look closer at the current structure). <img width="503" alt="Screenshot 2022-12-23 at 09 08 39" src="https://user-images.githubusercontent.com/595491/209298057-8929edcf-0b00-40d4-aed2-15b9e0a83db1.png";> This is a much more generic structure which is future-proof and usable by other provifers: * plugins/hive.py -> where the plugins live (and they expose macros) * macros/hive.py -> where macros live (those referred by the plugins) If we have listeners - we willl add them to `listeners/hive.py` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/595491/209298057-8929edcf-0b00-40d4-aed2-15b9e0a83db1.png"](https://user-images.githubusercontent.com/595491/209298057-8929edcf-0b00-40d4-aed2-15b9e0a83db1.png"){kind=link}