dstandish commented on code in PR #28336:
URL: https://github.com/apache/airflow/pull/28336#discussion_r1059320899
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -168,6 +168,7 @@ class KubernetesPodOperator(BaseOperator):
:param labels: labels to apply to the Pod. (templated)
:param startup_timeout_seconds: timeout in seconds to startup the pod.
:param get_logs: get the stdout of the container as logs of the tasks.
+ :param logs_timeout: timeout in seconds to read logs after container
termination.
Review Comment:
If the container is done, shouldn't there be no more logs forthcoming? In
which case, I'm not sure what need there would be to increase time beyond the 2
minutes. If there is a need to add configurability, we can always do so later.
It's easy to add things like this but much more difficult to remove or rename.
Current name is ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
