dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1060421477
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -187,8 +188,18 @@ def _group_logs_by_host(self, logs):
def _read_grouped_logs(self):
return True
+ @cached_property
+ def supports_triggerer(self):
+ """Not implemented yet."""
+ return False
Review Comment:
but the important point @uranusjr is....
if we do class variable, it propagates through inheritance... and this is a
no-no because subclasses need to be updated to properly work with triggers.
not huge updates in most cases. and the property on FTH is defined to be false
when not yet implemented (excepti my beautiful plan fails when mypy complains)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
