dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1061257494
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -187,8 +188,18 @@ def _group_logs_by_host(self, logs):
def _read_grouped_logs(self):
return True
+ @cached_property
+ def supports_triggerer(self):
+ """Not implemented yet."""
+ return False
Review Comment:
Not quite. Mypy complaints about the signature of _read in the subclass not
matching that of the parent because I updated the signature of the parent. This
left me with the choice of either removing type annotations from the subclass
method (thus avoiding mypy inspection) or updating the subclass method
signature even though I am deferring the act of actually updating the subclass
to work with triggers. Rather than remove the type annotations, I chose to
update the signature. But we use, in this property, inspection of this methods
signature to determine whether the subclass supports triggers. Therefore, it
would falsely indicate that the subclass does support triggers ( because the
subclass signature now has been updated ), therefore we have to implement the
property and return false. I did not try just adding it as an attribute because
the parent class is a property and I thought it best to stay consistent with
respect to that. When the subclass is ultimately updated to support
triggers, then we can remove this property from the subclass because the
parent class property will then tell the truth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
