Taragolis commented on code in PR #28706:
URL: https://github.com/apache/airflow/pull/28706#discussion_r1063303149
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -57,8 +57,14 @@ def wrapper(*args, **kwargs) -> T:
if "bucket_name" not in bound_args.arguments:
self = args[0]
- if self.conn_config and self.conn_config.schema:
- bound_args.arguments["bucket_name"] = self.conn_config.schema
Review Comment:
We need also provide backward compatibility with current version.
Basically we need to check `bucket_name` in both places:
1. In `service_config.s3.bucket_name`
2. Fallback to `conn_config.schema` and depreciation warning
This also could be done in
[AwsConnectionWrapper](https://github.com/apache/airflow/blob/8290ade26deba02ca6cf3d8254981b31cf89ee5b/airflow/providers/amazon/aws/utils/connection_wrapper.py#L76)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
