RachitSharma2001 commented on code in PR #28706:
URL: https://github.com/apache/airflow/pull/28706#discussion_r1064049945
##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -57,8 +57,14 @@ def wrapper(*args, **kwargs) -> T:
if "bucket_name" not in bound_args.arguments:
self = args[0]
- if self.conn_config and self.conn_config.schema:
- bound_args.arguments["bucket_name"] = self.conn_config.schema
+ if self.aws_conn_id:
+ conn_args = self.get_connection(self.aws_conn_id).extra_dejson
Review Comment:
That is a good point. I have added the property `service_config` to
`AwsGenericHook`, and now the conditional logic within `provide_bucket_name` is
a lot simpler, and it utilizes caching! Thank you for the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
