mhenc commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1066315168
########## airflow/api_internal/endpoints/rpc_api_endpoint.py: ########## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.processor import DagFileProcessor +from airflow.models.dag import DagModel Review Comment: `internal_api_call` decorator is client-side, while `METHODS_MAP` is at server-side. I agree that mixing the direction of imports may lead to the problems later. What about simply wrapping the building of `METHODS_MAP` into a additional method (with imports there). Like: https://github.com/apache/airflow/pull/28841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
