ferruzzi commented on code in PR #28755:
URL: https://github.com/apache/airflow/pull/28755#discussion_r1067293206
##########
tests/system/providers/amazon/aws/utils/__init__.py:
##########
@@ -92,15 +93,15 @@ def _fetch_from_ssm(key: str, test_name: str | None = None)
-> str:
:return: The value of the provided key from SSM
"""
_test_name: str = test_name if test_name else _get_test_name()
- ssm_client: BaseClient = boto3.client("ssm")
+ hook = SsmHook()
Review Comment:
Thinking this through, that would mean that the connection itself is not
being tested. Is that something we want to accept in a system test?
I think it's alright in this case. The system tests are supposed to be
testing the specific services, not whether the connection to SSM is working....
but that does mean it's a less-complete system test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
