ferruzzi commented on code in PR #28755:
URL: https://github.com/apache/airflow/pull/28755#discussion_r1067357578
##########
tests/system/providers/amazon/aws/utils/__init__.py:
##########
@@ -92,15 +93,15 @@ def _fetch_from_ssm(key: str, test_name: str | None = None)
-> str:
:return: The value of the provided key from SSM
"""
_test_name: str = test_name if test_name else _get_test_name()
- ssm_client: BaseClient = boto3.client("ssm")
+ hook = SsmHook()
Review Comment:
Yeah, I was digging in that code yesterday and one option I worked on was
adding AWS system tests as an exception and to assert that AWS tests make
exactly one query, but I don't really know how important that restriction is.
so I was trying to look into the restriction and why it's there. It looks like
your change does fix the test (this PR is passing now) so maybe let's run with
this.
@o-nikolas, can you have a look at this when you get a few minutes and let
me know what you think? I think I'm inclined to agree with Taragolis that this
is the right solution here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
