vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1381159841
> * Can this be more-universal across the provider? There are likely other operators that have the same thing, ISTR there are some EC2 operators. I didn't find other examples of this pattern in the AWS package, RDS, Sagemaker and S3 are the only 3 that popped up, but also it's a bit hard to grep for this. EC2 apparently only has 2 operators, to start/stop an instance ? And no tag formatting there. > * Do we show a concrete example of the two styles anywhere in the docs? > I'm not sure where the best place might be? It almost feels like it should be in a "top level" section like https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/index.html ? WDYT? No I don't think we do. It's true that it might be good to have it somewhere, but also, I'd hope for new users to use the dictionary approach, which is a lot more intuitive. Passing an already formatted list is not marked as so but is almost obsolete, I'm not sure we want to slap something on the front page advertising the complex approach when there is a simple one. I'd rather copy-paste an example in every docstring where necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
