ferruzzi commented on code in PR #28816:
URL: https://github.com/apache/airflow/pull/28816#discussion_r1071576124


##########
airflow/providers/amazon/aws/hooks/s3.py:
##########
@@ -42,6 +42,7 @@
 from airflow.exceptions import AirflowException
 from airflow.providers.amazon.aws.exceptions import S3HookUriParseFailure
 from airflow.providers.amazon.aws.hooks.base_aws import AwsBaseHook
+from airflow.providers.amazon.aws.utils.aws_api import format_tags

Review Comment:
   Pretty sure Jarek had mentioned not liking stuff in the __init__ files, so 
I've been trying to avoid it when I can think of a better name.  Sometimes it's 
easier than others.  Naming is hard.
   
   In this case I think aws_api.py is a sound option.  @eladkal - do you 
definitely want it changed or were you just making sure I was good with it? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to