ashb commented on code in PR #28926:
URL: https://github.com/apache/airflow/pull/28926#discussion_r1069504496
##########
tests/www/views/test_views_connection.py:
##########
@@ -40,11 +41,10 @@
"password": "admin",
}
-CONNECTION_WITH_EXTRA = CONNECTION.update(
Review Comment:
@ephraimbuddy I think this was your PR where we added it? Turns out that
`CONNECTION_WITH_EXTRA` was None (update returns in place, it doesn't return.)
Could you expand the test to check that x_secret and y_secret are actually
masked please? (separate PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
