potiuk commented on code in PR #28926:
URL: https://github.com/apache/airflow/pull/28926#discussion_r1069994094


##########
airflow/timetables/simple.py:
##########
@@ -55,6 +55,9 @@ def serialize(self) -> dict[str, Any]:
     def infer_manual_data_interval(self, *, run_after: DateTime) -> 
DataInterval:
         return DataInterval.exact(run_after)
 
+    def validate(self):

Review Comment:
   TIL.  Empty methods - whether ... or just with docstring **just work**. No 
matter if they are part of protocol or not:
   
   This one works fine and exit with 0 error code:
   
   ```python
   from typing_extensions import Protocol
   
   
   class A(Protocol):
       def method(self) -> None:
           """Empty method"""
   
       def method2(self) -> None:
           ...
   
   
   class B(A):
       def method3(self) -> None:
           ...
   
   
   B().method()
   B().method2()
   B().method3()
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to