potiuk commented on issue #22438:
URL: https://github.com/apache/airflow/issues/22438#issuecomment-1397677969

   > If I'm not mistaken, that would require changes to the system test runner 
which I think currently triggers on the "example" prefix. This was a holdout to 
when they were still example DAGs, so maybe the better solution would be to 
combine the example dags and the system tests into the tests tree, rename 
system test files something more obvious like {service}_system_test.py and use 
the new naming convention to trigger the CI tests.
   > 
   > That would require adjusting links to code snippets in the rst files. Any 
other side effects that I'm not thinking about?
   
   I think that. Any other side effects would be detected by failing CI (which 
is very comprehensive for those). This is not a "production" code, so I thinl 
even breaking small things there by going a bit ahead is fine. I am generally 
much more bold for test code than for production code (with the exception of 
making sure that the tests are run and actually test things) - any problems 
there are at most impacting developers, not users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to