vincbeck commented on PR #29144: URL: https://github.com/apache/airflow/pull/29144#issuecomment-1403836335
> I don't know about removal `moto` in this test, because it is a good framework for testing something more close to AWS implementation. Basically it just wrapper around [botocore.stub.Stubber](https://botocore.amazonaws.com/v1/documentation/api/latest/reference/stubber.html) with some helpers. > > Side effect with mock you really need to sure that you didn't do any mistake with mocking otherwise you easily could pass something that regular AWS environment and botocore/boto won't allow I agree with you but here, on the operator side, the direct dependency is the hook, so IMO we should mock the hook and not the AWS service (which is a dependency of the hook). We definitely can use `moto` to test the hook. But this might be not very pythonic to think that way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
