potiuk commented on PR #29143: URL: https://github.com/apache/airflow/pull/29143#issuecomment-1410353637
Very nice. Just a question - should not we make it back into the example_sensors.py and include from there? I think the big benefit of include_examples is that the doycumentaion can actually be tested very easily and in case we make any refactoring in the future it is far less likely to be "invalid" - and for example the discussion https://github.com/apache/airflow/pull/29143#discussion_r1086143815 would not be likely needed? I think the code could be simply copied into the example_sensors.py and end up with nearly the same result (barring the example_include header) Why not doing this way ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
