Taragolis commented on PR #29395: URL: https://github.com/apache/airflow/pull/29395#issuecomment-1420002526
> Yes. I just realized (sorry I was tired back then) that you already attempted to fix it. I guess I will spend couple of days before realise that the problem with URI encoding 🤦 I've already checked `connexion`, `werkzeug`, `marshmallow` 🤣 > Yes. I think we could combine those two PRs - and once mine gets green (I just pushed a fix) - we can add the try_fix_not_rfc3339_dt. We could combine or could make it as follow up. I do not have strong opinion for that and may be need more time for additional fixes in it. Potentially we could also drop some code which do not required anymore as follow-up, like this: https://github.com/apache/airflow/blob/2e1635a9c1d6faaa9d5cd5cfd1a364091cd62bde/airflow/api_connexion/parameters.py#L38-L53 >also > 4 on jsonschema should be added to this one (from your PR). Yep! This behaviour of `jsonschema` always confuse me - base on dependencies which install in environment behaviour of validation for date-time (and other to honest) could be different. I checked by `pipdeptree` and seems like we do not use it directly only pre-commit hooks and `moto` use it. Anyway sooner or later we would have to install `rfc3339-validator` as a dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
