potiuk commented on PR #29395: URL: https://github.com/apache/airflow/pull/29395#issuecomment-1420702344
Yeah. I am with @Taragolis here. > I think we use transformation by this function, unfortunately it happen after string validation. Previously it didn't failed because jsonschema doesn't validate datetime if rfc3339-validator or strict-rfc3339 (jsonschema<4) not installed. I think we need to bite the bullet now indeed. With Params it's a different story because we have full control over definition and validation and we even had an invalid example so far :( (so users might complain on it). But our Python/Go Clients for example would work correctly (I believe? - this is something we could possibly check with @pierrejeambrun ?) and I think for the APIs the standard compliance. The OpanAPI standard is very clear https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md#data-types: > string | date-time | As defined by date-time - RFC3339 There are no options here. "date-time" means RFC 3339. So what this change brings is a compliance with standards. Yes. It might cause some troubles, but this should be an easy fix for any "hand-crafted" client (And a good reason to use our Python client as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
