Taragolis commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1102125057
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -103,6 +106,7 @@ def __init__(
self,
*,
dynamodb_table_name: str,
+ dynamodb_conn_id: str | None = None,
Review Comment:
It is more about less known behaviour of boto3-based Hooks, `None` it is a
legit value and could force to use boto3 default behaviour strategy (without
any call to Connections), e.g. env Variables, IAM Profile, ECS Task Role and
etc.
I think better to use specific sentinel as default value instead of `None`
here
https://github.com/apache/airflow/blob/a76e0fe16ef12749c3fea1b68d82936b238fafbb/airflow/utils/types.py#L28-L44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
