Taragolis commented on code in PR #29452:
URL: https://github.com/apache/airflow/pull/29452#discussion_r1102515113
##########
airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:
##########
@@ -103,6 +106,7 @@ def __init__(
self,
*,
dynamodb_table_name: str,
+ dynamodb_conn_id: str | None = None,
Review Comment:
Well this behaviour not well documented - only in docstrings mentioned that
`aws_conn_id` (which propagated to AwsBaseHook) could apply `None` which
internally fallback to simple `boto3.session.Session(region_name=region_name)`.
We add some info about other very odd historical behaviour in documentation
for connection (see main brach
[docs](http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/docs/apache-airflow-providers-amazon/latest/connections/aws.html#default-connection-ids))
which also mention about `None` behaviour.
In Amazon Provider still a lot of inconsistent things between components,
especially in Operators and hooks which designed in Airflow 1.x, however every
release situation become better and better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
