pierrejeambrun commented on issue #41:
URL: 
https://github.com/apache/airflow-client-go/issues/41#issuecomment-1426180522

   Hello @bgoldman-videoamp,
   
   Thank you for reporting this. We are currently working on the release 
process of this package and your feedback is really welcome.
   
   ### Out of think submodule
   
   I think the intent of this top level module was to have a way to actually 
test the client, using 
[client_test.go](https://github.com/apache/airflow-client-go/blob/main/client_test.go).
 As you can see in the 
[go.mod](https://github.com/apache/airflow-client-go/blob/main/go.mod) it also 
depends on `testify` test library, so this will also add this unnecessary 
dependency to your project. There is no reason for airflow client to require 
this extra test dependency for production. (or add test code etc.)
   
   You can install directly the submodule:
   ```
   go get github.com/apache/airflow-client-go/airflow/@latest
   ```
   
   In this testing context, it explains why the top level dependency was almost 
never updated, the `replace` directive was enough for it to work as expected.
   
   Nonetheless it is really easy to update it, here is a PR for that, also 
adding install instructions https://github.com/apache/airflow-client-go/pull/42 
   
   ### II Tags Convention
   We followed the same tagging strategy that we use for airflow core and other 
api clients. Indeed, for Go It looks like tag needs to start with `v...` to be 
recognized as version for most tools. For now you can still use the hash commit 
to install a specific tag if needed (`go get 
github.com/apache/airflow-client-go/airflow/@<hashcommit>`), but we might want 
to change the way we tag release for Go client.
   
   I will open a separate PR to suggest this change.
   
   Thanks
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to