potiuk commented on code in PR #29375:
URL: https://github.com/apache/airflow/pull/29375#discussion_r1103844112
##########
tests/always/test_project_structure.py:
##########
@@ -90,8 +89,10 @@ def test_providers_modules_should_have_tests(self):
missing_tests_files = expected_test_files -
expected_test_files.intersection(current_test_files)
- with self.subTest("Detect missing tests in providers module"):
+ try:
Review Comment:
I see. Makes sense for subtest removal.
But why not just this:
```
assert set() == missing_tests_files, "Detect missing tests in providers
module"
```
##########
tests/always/test_project_structure.py:
##########
@@ -90,8 +89,10 @@ def test_providers_modules_should_have_tests(self):
missing_tests_files = expected_test_files -
expected_test_files.intersection(current_test_files)
- with self.subTest("Detect missing tests in providers module"):
+ try:
Review Comment:
I see. Makes sense for subtest removal.
But why not just this:
```python
assert set() == missing_tests_files, "Detect missing tests in providers
module"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
