ashb commented on code in PR #29714:
URL: https://github.com/apache/airflow/pull/29714#discussion_r1115770777
##########
tests/cli/commands/test_scheduler_command.py:
##########
@@ -73,6 +73,23 @@ def test_skip_serve_logs(self, mock_process,
mock_scheduler_job, executor):
scheduler_command.scheduler(args)
with pytest.raises(AssertionError):
mock_process.assert_has_calls([mock.call(target=serve_logs)])
+ @mock.patch.dict(
Review Comment:
Ahha, the problem is
https://github.com/apache/airflow/pull/29714/files#r1115484690
Because the value is set to `"False"`, i.e. a string, which is truthy.
Change it to `getboolean` and it works as expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
