tatiana commented on PR #29714: URL: https://github.com/apache/airflow/pull/29714#issuecomment-1443995416
> One option we have here would be to make the option an enum-based one instead of boolean, but with only two possible values (true and false). The check option can be investigated later. @uranusjr I just checked Airflow's code, and it seems there isn't a neat way of converting configs into an enum, since we use `ConfigParser`. I am concerned about prematurely handling it like we did with `expose_config` (https://github.com/apache/airflow/blob/main/airflow/www/views.py#L3894). It would make the code more complex without any benefits. Would it be a problem if we started by having `check_migration` as a `boolean`, as it is now? If (and when) we decide to introduce the `check` value in the future, we could change the type to a `string` - WDYT? Please let me know if you like any further changes to the current PR before it can be merged. Moving forward, one possibility for handling `Enum`s more gracefully could be to move out of `ConfigParser` and use something like `Open API` or `Swagger` to do the type checking - but I think that is a discussion for a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
