ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix
LocalTaskJob heartbeat log spamming
URL: https://github.com/apache/airflow/pull/5589#discussion_r303379011
##########
File path: airflow/jobs/base_job.py
##########
@@ -192,7 +192,7 @@ def heartbeat(self):
self.heartbeat_callback(session=session)
self.log.debug('[heartbeat]')
except OperationalError as e:
- self.log.error("Scheduler heartbeat got an exception: %s", str(e))
+ self.log.exception("%s heartbeat got an exception: %s",
self.__class__, str(e))
Review comment:
This will also include the stack trace of the exception - was that intended?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
