ashb commented on a change in pull request #5589: [WIP][AIRFLOW-4956] Fix
LocalTaskJob heartbeat log spamming
URL: https://github.com/apache/airflow/pull/5589#discussion_r303381221
##########
File path: airflow/jobs/local_task_job.py
##########
@@ -103,16 +100,8 @@ def signal_handler(signum, frame):
# Periodically heartbeat so that the scheduler doesn't think
this
# is a zombie
- try:
- self.heartbeat()
- last_heartbeat_time = time.time()
- except OperationalError:
- Stats.incr('local_task_job_heartbeat_failure', 1, 1)
Review comment:
I guess this removes this metric - we should probably add a note about that
to UPDATING.md, or add it back in in some fashion inside BaseJob.heartbeat?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
