potiuk commented on code in PR #29776: URL: https://github.com/apache/airflow/pull/29776#discussion_r1118647851
########## tests/models/test_pydantic_models.py: ########## @@ -0,0 +1,151 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from pydantic import parse_raw_as + +from airflow.jobs.local_task_job import LocalTaskJob +from airflow.jobs.pydantic.base_job import BaseJobPydantic +from airflow.models.dataset import ( + DagScheduleDatasetReference, + DatasetEvent, + DatasetModel, + TaskOutletDatasetReference, +) +from airflow.models.pydantic.dag_run import DagRunPydantic +from airflow.models.pydantic.dataset import DatasetEventPydantic +from airflow.models.pydantic.taskinstance import TaskInstancePydantic +from airflow.utils import timezone +from airflow.utils.state import State +from airflow.utils.types import DagRunType +from tests.models import DEFAULT_DATE + + +def test_serializing_pydantic_task_instance(session, create_task_instance): + dag_id = "test-dag" + ti = create_task_instance(dag_id=dag_id, session=session) + ti.state = State.RUNNING + ti.next_kwargs = {"foo": "bar"} + session.commit() + + pydantic_task_instance = TaskInstancePydantic.from_orm(ti) + + json_string = pydantic_task_instance.json() + print(json_string) Review Comment: I did try to make them (both) work. But either I am too stupid or the documentation is completely misleading. I simply don't know how to make sure classes and related entitites (if they have them) can be serialized in a single go with them. But if someone would like to make a parallell POC witth them - I would love to see it. I think wiht this PR it's rather straightforward what we want to achieve and which entites should be made serializable. If we can make them without Pydantic - I am all ears (not that Pydantic **just works** with just defining the entities and marking them to work in `orm_mode`. I wanted to avoid writing any code on our side to do the serialization, so if we could make it even simpler than that - I am all ears actually :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
