potiuk commented on PR #29776: URL: https://github.com/apache/airflow/pull/29776#issuecomment-1458907186
> Thank you! This looks really cool. > > Just to confirm I understand it correctly: After this PR is merged, we need to change methods using TaskInstance parameter to use `TaskInstance|TaskInstancePydantic`, e.g. in run_raw_task > > https://github.com/apache/airflow/blob/f1b565f1175121451a5bdfaaa19831f0ed8b4d54/airflow/cli/commands/task_command.py#L277 > > > I think the `ti._run_raw_task` need also be updated (to static method?) to work with both TaskInstance and TaskInstancePydantic. Yeah. Rouhgly speaking. This might be a bit more involved in a few places (for example we will have to split some methods into two etc. But yeah, roughly speaking that what's it is. I have an (unfinished) example of local job refactor that would use that approach https://github.com/apache/airflow/commit/f11f5afbddfe39a9f0e31bc1fc1ba3cc1dfa5394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
