syun64 commented on PR #29881: URL: https://github.com/apache/airflow/pull/29881#issuecomment-1454941871
> I think it is very confusing as defined now. I think we should change "allow_list_validator" field into "list_validator" and have two implementations: > > * AllowListValidator > * BlockListValidator > > And let the user choose which validator to use (by name for example). The way where you invert meaning of a list is super confusing. IMHO I see what you are saying @potiuk . I've made your suggested changes in stats.py. I've also introduced a separate `statsd_block_list` config parameter that expects a comma delimited string instead of `statsd_invert_allow_list`. Made a note on the config comment to note that if both statsd_allow_list and statsd_block_list are set, then statsd_block_list will be ignored in favor of statsd_allow_list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
