hussein-awala commented on code in PR #29881:
URL: https://github.com/apache/airflow/pull/29881#discussion_r1125753666
##########
airflow/stats.py:
##########
@@ -291,10 +315,11 @@ def wrapper(self, stat=None, *args, tags=None, **kwargs):
if self.influxdb_tags_enabled:
if stat is not None and tags is not None:
for k, v in tags.items():
- if all((c not in [",", "="] for c in v + k)):
- stat += f",{k}={v}"
- else:
- log.error("Dropping invalid tag: %s=%s.", k, v)
+ if self.metric_tags_validator.test(k):
Review Comment:
My bad, I thought that this filter:
```python
tags_list = [
f"{key}:{value}" for key, value in tags.items() if
self.metric_tags_validator.test(key)
]
```
is used for the two clients datadog and influxdb, but just found that is
just used for datadog, and `if self.metric_tags_validator.test(k):` is used for
influxdb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
