argibbs commented on code in PR #29933:
URL: https://github.com/apache/airflow/pull/29933#discussion_r1126170057
##########
airflow/sensors/external_task.py:
##########
@@ -130,29 +142,31 @@ def __init__(
):
super().__init__(**kwargs)
self.allowed_states = list(allowed_states) if allowed_states else
[State.SUCCESS]
+ self.skipped_states = list(skipped_states) if skipped_states else []
self.failed_states = list(failed_states) if failed_states else []
- total_states = set(self.allowed_states + self.failed_states)
+ total_states = set(self.allowed_states + self.skipped_states +
self.failed_states)
- if set(self.failed_states).intersection(set(self.allowed_states)):
+ if len(total_states) != len(self.allowed_states + self.skipped_states
+ self.failed_states):
raise AirflowException(
- f"Duplicate values provided as allowed "
- f"`{self.allowed_states}` and failed states
`{self.failed_states}`"
+ f"Duplicate values provided across allowed_states,
skipped_states and failed_states."
Review Comment:
Have fixed a few of these in the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
