argibbs commented on code in PR #29933:
URL: https://github.com/apache/airflow/pull/29933#discussion_r1130571124
##########
airflow/sensors/external_task.py:
##########
@@ -273,6 +284,31 @@ def poke(self, context, session=None):
)
raise AirflowException(f"The external DAG
{self.external_dag_id} failed.")
+ count_skipped = -1
+ if self.skipped_states:
+ count_skipped = self.get_count(dttm_filter, session,
self.skipped_states)
+
+ # Skip if anything in the list has skipped. Note if we are checking
multiple tasks and one skips
+ # before another errors, we'll skip first.
Review Comment:
So just to follow up on this, I'm not opposed to making the behaviour more
nuanced - in fact if I see an issue in the future on this area I might pick it
up - but if you're ok with it as is, I'd prefer to keep the change fairly
minimal to start with?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
