casra-developers commented on code in PR #29935:
URL: https://github.com/apache/airflow/pull/29935#discussion_r1127564866
##########
airflow/jobs/local_task_job.py:
##########
@@ -263,7 +263,7 @@ def heartbeat_callback(self, session=None):
recorded_pid = psutil.Process(ti.pid).ppid()
same_process = recorded_pid == current_pid
- if recorded_pid is not None and not same_process:
+ if not IS_WINDOWS and recorded_pid is not None and not
same_process:
Review Comment:
I guess it boils down to how differently processes are managed in Windows
and POSIX based systems. Since we rely on Airflow being available for our
business I had to implement a hotfix quickly and did not investigate the entire
task lifecycle. My suspicion is that a major refactoring would be required to
make the process identification OS agnostic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
