uranusjr commented on code in PR #29935:
URL: https://github.com/apache/airflow/pull/29935#discussion_r1127578925
##########
airflow/jobs/local_task_job.py:
##########
@@ -263,7 +263,7 @@ def heartbeat_callback(self, session=None):
recorded_pid = psutil.Process(ti.pid).ppid()
same_process = recorded_pid == current_pid
- if recorded_pid is not None and not same_process:
+ if not IS_WINDOWS and recorded_pid is not None and not
same_process:
Review Comment:
Existing usages of `IS_WINDOWS` (and the other two in this PR) are around
things that are handled very differently on Windows (ownership, permission,
etc.), but Windows do have pids and they mean the same thing as Linux, so I’m
confused why this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
