jedcunningham commented on code in PR #29929:
URL: https://github.com/apache/airflow/pull/29929#discussion_r1134717338
##########
airflow/kubernetes/kubernetes_helper_functions.py:
##########
@@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) ->
TaskInstanceKey:
try_number=try_number,
map_index=map_index,
)
+
+
+def annotations_to_str(annotations: dict[str, str]) -> str:
+ return json.dumps(annotations)
Review Comment:
I meant that we already [log TI key and pod_id
together](https://github.com/apache/airflow/blob/198408e4531dea7eaba5b64bdb0f0d2b74062878/airflow/executors/kubernetes_executor.py#L350),
so logging the same stuff on each line seems like it could be redundant. I'm
curious to see what others think though - I'm not saying no, I'm just saying
I'm not sure we need it.
logfmt vs json: Yeah, probably out of scope for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
