hussein-awala commented on code in PR #29929:
URL: https://github.com/apache/airflow/pull/29929#discussion_r1137720316
##########
airflow/kubernetes/kubernetes_helper_functions.py:
##########
@@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) ->
TaskInstanceKey:
try_number=try_number,
map_index=map_index,
)
+
+
+def annotations_to_str(annotations: dict[str, str]) -> str:
+ return json.dumps(annotations)
Review Comment:
I agree with @jedcunningham, where all the log collectors add metadata about
the log source, and we can use them to filter the log
But if we have a real need for some users, we can add a config to
enable/disable adding these extra information in each line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
