eladkal commented on code in PR #30032: URL: https://github.com/apache/airflow/pull/30032#discussion_r1136201716
########## airflow/providers/amazon/aws/hooks/base_aws.py: ########## @@ -42,6 +42,7 @@ import botocore.session import requests import tenacity +from aiobotocore.session import AioSession, get_session as async_get_session Review Comment: > if someone would like to use newer boto3 and not use aiobotocore extra - it will be possible for them to upgrade boto (and we can also document). There will be no "check" that the newer version will work - as we will not run tests for it - but the user will be able to do their own tests and use newer boto. We will not prevent that. I'm cool with this. I'm just saying that there is also the option of the other way around. Till native and conflictless approach introduced, maybe async operators should be external in their own dedicated package and to be installed by users who seek to use triggers? That way current behavior and expectations are not sacrificed and who ever wants the new functionality can install it like any 3rd party provider. I'm worried that we may underestimate the impact of limiting boto3. > We have to sacrifice something I'm OK with any decision on this. I just want to make sure that all aspects were taken into account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
