potiuk commented on code in PR #30127:
URL: https://github.com/apache/airflow/pull/30127#discussion_r1139853973
##########
setup.py:
##########
@@ -399,6 +399,8 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT
/ "airflow" / "git_ve
"wheel",
"yamllint",
"aioresponses",
+ # TODO: why??
+ "aiobotocore>=2.1.1",
Review Comment:
Also I just created o#30161 that adds flexibility in switching between the
two choices by separating aiobotocore to be separate extra for Airflow. This
also makes sure that (in the current approach) aiobotocore is installed in the
PROD image of airflow - which makes deferrable operators work truly
"out-of-the-box" in the released Airflow image (I forgot about it while
commenting on #30127).
This also shows another consequence that you should be aware @o-nikolas
@shubham22 @syedahsn
* If we go for 1) then deferrable operators will work out-of-the-box with
the regular PROD image of airflow (with older botocore/boto). Users will be
able to build their image with the latest botocore with something like that:
```
FROM apache/airflow:2.6.0-python3.9
RUN pip uninstall aiobotocore && pip install --upgrade botocore boto # no
constraints here, they will be incompatible
```
But they loose deferrable operators this way.
* If we go for 2) then deferrable operators will not work out-of-the-box but
the botocore/boto will be latest at the moment of release. Users will have to
do something like that (this will downgrade botocore) and build their image (or
equivalent way of building the image for your service)
```
FROM apache/airflow:2.6.0-python3.9
RUN pip install aiobotocore==2.5.0 # no constraints here, they will be
incompatible
```
I hope this will keep you better informed on the choices we have - happy to
hear which of the two is your preference. I am ok with both approaches (and
there is basically no other way to handle it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
