o-nikolas commented on code in PR #30127:
URL: https://github.com/apache/airflow/pull/30127#discussion_r1140550944
##########
setup.py:
##########
@@ -399,6 +399,8 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT
/ "airflow" / "git_ve
"wheel",
"yamllint",
"aioresponses",
+ # TODO: why??
+ "aiobotocore>=2.1.1",
Review Comment:
Personally I prefer the approach of shipping with aiobotocore/async support
by default. I think this has two benefits:
1. A more complete functioning product ships by default, the user doesn't
need to do anything specific to use deferrable operators. It is more user
friendly.
1. I prefer the scenario where boto/botocore version is restricted from the
outset. This sets a better expectation of what features will be available for
all usecases. The opposite approach allows users build dependencies against
current boto features and then if they enable async they lose those features.
This is a bad and confusing user experience (or at least, worse of the two
options IMHO).
I'm curious to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
