ashb commented on code in PR #29809:
URL: https://github.com/apache/airflow/pull/29809#discussion_r1141851658
##########
tests/kubernetes/test_client.py:
##########
@@ -81,3 +85,19 @@ def test_disable_verify_ssl(self):
else:
configuration = Configuration()
assert not configuration.verify_ssl
+
+ def test_api_client_retry_configuration_default(self):
+ conf = initialize_config()
+ api_client_retry_configuration = conf.getjson(
+ "kubernetes", "api_client_retry_configuration", fallback={}
+ )
+
+ assert api_client_retry_configuration == {}
Review Comment:
Remove this test, It's not testing anything other than the upstream
`fallback` behaviour.
##########
airflow/kubernetes/kube_client.py:
##########
@@ -107,23 +109,34 @@ def get_kube_client(
if conf.getboolean("kubernetes_executor", "enable_tcp_keepalive"):
_enable_tcp_keepalive()
+ new_client_config = _get_default_configuration()
Review Comment:
Nit: you can make the configuration smaller by keeping this variable
```suggestion
configuration= _get_default_configuration()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
